Actually make sure conda env dir is set on Buildkite CI #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original fix was incorrect due to https://buildkite.com/docs/pipelines/environment-variables#runtime-variable-interpolation, but happened to pass by coincidence.
CarloLucibello
approved these changes
Mar 15, 2023
marius311
added a commit
to marius311/Zygote.jl
that referenced
this pull request
Mar 20, 2023
[Diff since v0.6.58](FluxML/Zygote.jl@v0.6.58...v0.6.59) **Merged pull requests:** - Actually make sure conda env dir is set on Buildkite CI (FluxML#1392) (@ToucheSir) - generated z2d (FluxML#1394) (@chengchingwen) - bump version (FluxML#1398) (@chengchingwen)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original fix was incorrect due to https://buildkite.com/docs/pipelines/environment-variables#runtime-variable-interpolation, but happened to pass by coincidence. Now that I know what to look for, it should be easy to verify this is doing the right thing,